JP Simard
JP Simard
If porting this rule introduces some regressions but is overall more robust, I'm not opposed to that tradeoff, but it'd be nice to avoid regressions. Let me know if you'd...
If we add the swift syntax folding code, maybe that should go in a new `SwiftSyntaxFolding` module?
The new violations flagged by OSSCheck should probably not be reported: https://github.com/realm/realm-cocoa/blob/95ebae968d1183decef9ac5990a7f097d02b603e/RealmSwift/Tests/ModernObjectAccessorTests.swift#L341:27 I don't think it's in the spirit of this rule to include function call expressions.
> Updated it to use the new `SwiftOperators` package. Nice!
You're right, not a dupe! Do you happen to know if Xcode exposes an API to provide fix-its? So far, we've been able to avoid making an Xcode plugin and...
@segiddins do you know what the format should be to suggest a fix-it to Xcode?
@julien-c I think you're confusing "Xcode Fix-Its" (this issue), with #5 (the ability to automatically correct violations).
More info on Xcode Fix-Its can be found in Apple's documentation: https://developer.apple.com/library/ios/recipes/xcode_help-source_editor/chapters/Fix-it.html
Then the private way it will be!
> what is the private way to add fix-it? Xcode Plugins, and no, Xcode Source Extensions don't expose a way to do that, so this would have to be done...