JP Robinson

Results 25 comments of JP Robinson

I think a very large portion of whats above is from the examples, but some is also coming from the Google and AWS tooling within the pubsub packages. For those...

Howdy @alessandrozucca! Sorry for the delay, I've been thinking about this one since you posted. While it does seem handy, I do worry about this leading to a leaky abstraction...

I'm fine with dropping stdlib and leaning purely on gorilla/mux. I think this just came from the "router wars" days. I shouldn't have accepted those PRs 😅

I'm a bit more inclined to go the document-driven approach. Create a API spec and then create servers and clients based on the contract. Also, if we do build a...

Similar to my thoughts in #186, I'm down for a spec driven approach. I've tried this a few times, but the projects always sizzled out as I've run out of...

I'm in for hooking Prometheus into the `kit` server as well. Following along with my comments in the `gcputil` branch, I wonder if we can just have that package return...

The `kit` server allows folks to provide their own custom mux, but I think that may be tossing the problem over the fence at the user. They'd still have to...

Howdy @acsbendi! It looks like you may be attempting to build against the latest version of that prometheus client. With Go Modules, [gizmo currently has that client pinned at version...

The plus for embedding the router is that it takes another decision out of the way for developers. One way of maintaining that would be to go the `RouterOption` route...

@jared2501 this seems like a reasonable addition to me. The code looks like it's in a good place. Go ahead and add some tests and I'll bring this in. Thanks!