Adrien Grand
Adrien Grand
> IMHO, Elasticserach should use fixed size threadpools (there can be many threads in it, the problem is huge pool that spawns new threads all the time and discards them...
I think there is another issue with this PR, which is that if a vInt is written across two ByteBuffers, then your PR would only ensure the validity of one...
Thanks @gf2121 the implementation looks correct to me now. Are you still seeing a good speedup with this change?
I wonder if one reason why this helps is because this method is so large that it is prevented from inlining sub function calls. The JVM bug that affected vint/vlong...
Interesting, so it looks like rolling the loop back actually helps a bit. Can you open a new JIRA/PR for this change specifically @gf2121 ?
@gf2121 Do you have an email I can use to contact you? Please send me an email at [email protected] if you don't want to leave it on GitHub.
> from the perf results so far, it seems using the most weighted field to decide on the leading impacts may not yield the best result > Are you trying...
These numbers are super interesting. Let's go with the approach of you baseline for now since it performs better, sorry for putting you on a track that performs worse. :)...
Indeed I wanted to get something out quickly for benchmarking where I could easily play with different block sizes, while ForUtil is very rigid (hardcoded block size of 128 and...