Adrien Grand

Results 310 comments of Adrien Grand

In my experience, binary doc values are more often used to encode structured data, such as maps that help build scoring signals, geo shapes, etc. than actual binary content, so...

Another argument in favor of this proposal that I can think of is that many call sites of this API want to decode numbers from the byte[] and end up...

@albogdano I'm curious if you have any interest in contributing your https://github.com/albogdano/lucene-s3directory? @shubhamvishu @atris Thanks for volunteering to help! I'm keen on checking if @albogdano has interest in contributing first,...

I'm thinking of a PR that would create a new `lucene/directory/s3` module where we'd check in the code. > proof of concept What is your gut feeling: should we rather...

Sounds good. Would you like to work on the PR?

No special requirements, you may just need to adjust formatting (running `./gradlew tidy`) and make sure it conforms with other requirements that are checked by the build, like forbidden APIs.

I tried to reproduce the slowdown locally by - comparing on the commit just before we started requiring Java 24, with the baseline on Java 23 and the contender on...

I believe that this change from @uschindler for instance requires Java 24 https://github.com/apache/lucene/commit/10c31217a91563ce42a0ab26a677738c181a7b63.

Maybe you could compare performance with Java 23 on the commit before Lucene started requiring Java 24 (612f0da4a4ce3a133b40402a87ec5cf7eeb290cc). If performance is still bad, this would indicate that the regression is...

It looks like nightly benchmarks only run every 2 days since May 13th, vs. every day before that. Is this because it now takes longer to run the benchmark?