James McKinney

Results 188 comments of James McKinney

I see the project has no PO or MO files. If I were to provide Spanish and French translations, would they be merged?

My understanding is that at minimum MO files must be committed in the theme, e.g. https://github.com/sphinx-doc/sphinx/tree/4.x/sphinx/locale contains strings for files in the basic theme. Same for [sphinx_rtd_theme](https://github.com/readthedocs/sphinx_rtd_theme/tree/master/sphinx_rtd_theme/locale) and others. Committing...

Why is there a `_templates` directory? Py-Babel will not look in directories with an underscore: https://github.com/python-babel/babel/blob/5afe2b2f11dcdd6090c00231d342c2e9cd1bdaab/babel/messages/extract.py#L140-L143 I don't think the theme should be using `_templates`...

Hmm, well I think it's fine for a theme to use any name. I remove the `_` in #399.

I'm a bit confused why some templates are in `pydata-sphinx-theme` and others are in `_templates`, TBH.

I much prefer this at the bottom, since 99% of users do not want to edit this page. See e.g. Docusaurus: ![Screen Shot 2021-05-07 at 3 24 41 PM](https://user-images.githubusercontent.com/26463/117498914-7166ca00-af48-11eb-8098-32be4fc42b15.png) (Taken...

A lot of similar issues like #146, in addition to those mentioning this issue above. Can they be consolidated?

This should work now. I'll test on my docs site.

Okay, this is ready for review. It works!

I've updated `contributing.rst` and accepted the suggestions. Not clear what to change in `i18n.rst`.