James McKinney

Results 188 comments of James McKinney

I've added some more tests in #459. I haven't added a test for rendering HTML with `gettext_additional_targets`, because the current behavior is incorrect. Below is a test for that once...

I've created a PR with a failing test: https://github.com/executablebooks/MyST-Parser/pull/360

> Hmm, ok cheers so the label of an admonition get turned into an anchor. I was not aware of that, and it feels like that should not be the...

You might be able to create a workaround like this solution to a similar problem: https://github.com/executablebooks/MyST-Parser/issues/444#issuecomment-1179796223

I’ve never used footnotes (I sometimes forget they exist) so this scenario wasn’t covered in the tests. I’ll try to have a look.

Hmm, in the past I looked at how I fixed i18n in recommonmark, but recommonmark never supported footnotes: https://github.com/readthedocs/recommonmark/issues/62 I can reproduce the error, but I have no idea. The...

Some of the changes to the tests fixtures for later (I haven't updated the XML and HTML fixtures, as the warning interferes). This patch is based off #459: ````diff diff...

In case anyone else comes across this warning, I like to turn warnings into errors with `PYTHONWARNINGS=error`. I tried ignoring this particular warning with: ``` PYTHONWARNINGS=error,ignore::ImportWarning:yaml._yaml PYTHONWARNINGS=error,ignore::ImportWarning:yaml.cyaml PYTHONWARNINGS=error,ignore::ImportWarning:yaml ``` Those...

FYI, those directives are from http://clarkgrubb.com/makefile-style-guide#prologue