Josh Pike
Josh Pike
@Bin-Huang Eyeballing and testing your latest update I'm glad you're doing a great service for the community. You haven't pushed your business on people, just decided to focus on something...
I may just copy from the terminal into vscode search to easily hone in on the problem error, that's all.
+1.... this is one of those things that just would make things perfect if possible
potentially relevant reading: https://www.reddit.com/r/RetroPie/comments/86snpv/a_guide_to_improve_n64_audio/
Can this be made a priority? TS defintion support is the standard nowadays, wouldn't be a bad idea either to convert this project to TS
+1 for this, I've switched from mysql to Postgres, and this was a shock... considering that Postgres actually doing everything SQL compliant and others aren't.
The worst part is that the query fails silently, if using Postgres it should at least throw an error.
I think it's worth implementing a stopgap solution. Perhaps if it was possible to add some sort of validation method on update that can inspect the AST of the query...
Another one that is a gotcha for PostgresSQL users... this knex command will silently create an invalid query: ``` await sql .knexMaster('user') .join(sql.Table.Business, 'user.businessID', 'business.id') .where('user.id', creatorID) .increment('bookingCounter', 1); ```...
Which would be more ideal: - The ability to import a Typescript definition set that overrides existing types for a given dialect (e.g. a type that excludes join when update...