Josh Pike

Results 295 comments of Josh Pike

Just migrated from another bundler expecting this to be a thing... but it isn't. The Angular CLI leaves a lot to be desired.

I'm all for this, it doesn't need to be complicated either. Need it for CodeBuild. Is anyone planning on doing this?

https://github.com/Microsoft/vscode/issues/21423

Closed, but worth reading the above link. What do you think

@DABH any comments on this? https://github.com/Microsoft/vscode/issues/21423#issuecomment-373966489

Oh my god. I found the problem. colors.supportsColor returns false on esm-enabled projects. That's not good.

Ok that was premature, ignore. But I'm close

https://github.com/Marak/colors.js/blob/dc82cc01d00df2f1cdcf90cba699a5a61da70446/lib/system/supports-colors.js#L69 My stream object has the _type property set to "pipe", instead of "tty". This makes the isTTY check fail, and I get no styling. The weird part is that...

Bonus weirdness, works fine with another developer's project. I'm on OSX and he's on Windows 10. And I've double check I have the latest colors.js installed in mine.