Julien Phalip

Results 26 comments of Julien Phalip

Thanks for the reply. Where should I look exactly for the logs? Also, how can I look up the value of `datanucleus.autoStartMechanismMode`? I'm not sure where to look for those...

Would it make sense to still set the `setThrowNotFound` option? That shouldn't break the Spark code (since it already checks the table's existence prior), and would allow the Hive connector...

I ended up making an extra call to BigQuery to check the table's existence upfront: https://github.com/GoogleCloudDataproc/hive-bigquery-connector/commit/dafa09f2177b4134c124a81908a5171c12987580 Would still be nice to update `ReadSessionCreator.create()` to directly handle that edge case so...

That sounds like an interesting idea. Could you write a quick proof-of-concept for this?

Nice, I really like this feature. Thanks for the suggestion. Here are a few comments: - Could the parameter be named "ignore" instead of "whitelist". I think that would make...

My recommendation is specifically to use `find_elements_by_css_selector()` to retrieve the elements, since `querySelector()` has some limited support in old browsers like IE 8 (granted, that's not a huge deal). Then...

Thanks for the updates. First, one small comment: I think we should assume that the provided CSS selectors might potentially return multiple elements. So, could you use `find_elements_by_css_selector()` (note the...

Thanks for the report. @sterago, could you confirm if this patch below would fix your issue? ``` diff diff --git a/needle/engines/perceptualdiff_engine.py b/needle/engines/perceptualdiff_engine.py index 33ef157..bdf1777 100644 --- a/needle/engines/perceptualdiff_engine.py +++ b/needle/engines/perceptualdiff_engine.py @@...

To me this looks like a potential bug with Selenium itself. Which version of Selenium are you using, and have you tried upgrading to the latest version?

Thanks. My gut feeling is that it's a bug with the Selenium package with regard to Firefox. I haven't had a chance to test firsthand yet though. On a side...