José Pereda

Results 217 comments of José Pereda

@erwin1 could we add the self hosted runner so we can also build for M1?

This is how you can reproduce the issue: - Open SB, new empty template - Drag a TabPane from Containers - Drag a Tab from Containers into the TabPane. It...

Doing a quick test on Mac: Seems like `iconView.setFitHeight`, `iconView.setFitWidth` don't have any effect, and imageView uses the size of the icon (which works fine if the menubar is not...

Seems that [`GlassSystemMenu::getPixels`](https://github.com/openjdk/jfx/blob/master/modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/GlassSystemMenu.java#L292) doesn't check other than the url of the image to get the pixels down to native. So you'll need to provide a smaller size for the icons?

That won't work for Mac, see https://github.com/openjdk/jfx/blob/master/modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/GlassSystemMenu.java#L293: only ImageView...

@AlmasB I've added some comments. @gargoyle Looks good, it's also great that you created the OpenJFX PR.

@Clashsoft This [branch](https://github.com/jperedadnr/javafx-gradle-plugin/tree/Java8) has a possible version of the plugin that runs with any JDK 8+. If you want to give it a try, clone, build (with any JDK), and...

@shahzaibj As per our [contributions](https://github.com/openjfx/javafx-gradle-plugin#issues-and-contributions) guidelines, could you please sign the CLA[https://cla.gluonhq.com/] before we can move forward with this PR?

While it shouldn't have adverse effects, it shouldn't happen in the first place. The main reason to find artifacts from wrong platforms is having dependencies of third party libraries that...