Jose Pedro Pereira dos Santos
Jose Pedro Pereira dos Santos
The integration tests fail because of the "api-approved.kubernetes.io" in the two added CRDs (AppGroup & NetworkTopology). I was able to run my integration tests successfully locally after I manually edited...
> > So, how should I proceed to take care of this issue for this PR since both CRDs are not approved yet? What is the proper way to add...
Hi @Huang-Wei, I believe I solved the issues with the integration tests. Also, I have reduced the size of the PR: 1) CRDs + API definitions Perhaps better to wait...
/remove-lifecycle stale Please let me know if I can provide further help/info on the PR revision.
Hi @ingvagabund and @Huang-Wei, Thank you for your revision! I will be working on the suggested code modifications. For me it's fine if we keep the CRDs + controllers outside...
Hi @ingvagabund and @Huang-Wei, We decided to host the multiple components in the following repo: [Diktyo-io](https://github.com/diktyo-io) Regarding the PR, do you prefer to do the modifications in this PR (remove...
> Thanks @jpedro1992 ! > > First round of review. (TODO: score and tests) > > BTW: would you mind crafting an integration test? Thanks for the review @Huang-Wei! I...
> /close in favor of #432 I agree.