Results 225 comments of James Peach

> Hm, this is breaking remote preprocessing because including all the arguments when detecting dependencies is problematic. e.g. it's very important that we strip any existing `-M*` arguments when we...

FWIW, I tried this quick hack with the Envoy build, and it ended up not being able to resolve libstdc++ types properly. Not sure whether there's something more needed to...

OK, I figured this one out. We need to pass all the Defs along to the remote build as well as the `-frewrite-includes` flag. Clang also needs different constants in...

> I don't think the operator necessarily needs to manage the CRDs itself; rather, the CRDs can be packaged with the operator. If the operator upgrades contour controller versions, then...

> > If the operator upgrades contour controller versions, then I think that it ought to upgrade the CRD, since the versions are often locked or interdependent. > > @jpeach...

go-bindata is now at https://github.com/go-bindata/go-bindata

> Looks like https://github.com/go-bindata/go-bindata is not actively maintained, and there is discussion of changing to https://github.com/kevinburke/go-bindata in Kubernetes: > [kubernetes/kubernetes#96169](https://github.com/kubernetes/kubernetes/issues/96169) Apparently [embed](https://tip.golang.org/pkg/embed/) is coming to Go 1.16.

It's possible to deploy multiple contours in the same namespace, or multiple contours in a namespace each. The operator will need to configure leader election carefully to make both these...

> We use it in mainline Contour, so I'm supportive. Yeh we don't use the whole framework, but the `require` and `assert` packages are pretty handy and save a bunch...