James Peach
James Peach
> Is it possible to add a new happy-path test to `test/test.sh` to test this new functionality? It would be good to have a test that verifies the ocb can...
Pretty sure that this PR doesn't break contrib-tests.
``` # github.com/influxdata/influxdb-observability/common Error: /home/runner/go/pkg/mod/github.com/influxdata/influxdb-observability/[email protected]/metrics_sort.go:56:43: hdp.MExplicitBounds undefined (type internal.HistogramDataPoint has no field or method MExplicitBounds) Error: /home/runner/go/pkg/mod/github.com/influxdata/influxdb-observability/[email protected]/metrics_sort.go:57:21: hdp.MExplicitBounds undefined (type internal.HistogramDataPoint has no field or method MExplicitBounds)
> LGTM, but the versions need to be bumped. Updated
> @jpkrohling can you document the motivation? Does not seem to be that useful to produce a standard collector that we already produce and release anyway? Originally, when you ran...
> Also this overlaps somewhat with what the [`zpages` extension](https://github.com/open-telemetry/opentelemetry-collector/tree/main/extension/zpagesextension) does. It may be a better idea to add it there, rather than on a subcommand, which is something we...
> Since we all agree that zpages is a must, let's do that I think that's a separate PR. It doesn't work for my use case, which is to check...
> > Since we all agree that zpages is a must, let's do that > > > > I think that's a separate PR. It doesn't work for my use...
Yeh, I think you are right; this is more problematic the more you think about it. I poked at this using `strings.Replacer` which kinda works because all the types are...