Juan Pablo Djeredjian
Juan Pablo Djeredjian
@banderror Fixed the TimeDuration type to make its time units configurable. Want to take one final look? Also, I'm about to put up for review[ this PR with the fixes...
> @jpdjere, @banderror what's the reasoning behind? > > > Remove option for “Perform no actions” from the bulk update rule actions dropdown options ONLY (option still available when creating...
**TODO:** - find out how (and if it is possible) to expose the `xpack.alerting.rules.run.alerts.max` setting to the frontend. Alternatively, consider throwing an error/warning only onSave **Update:** This value is exposed...
@approksiu @ARWNightingale I don't think we really need designs for this (maybe for link to docs, and explanation in tooltip?), but I think we can agree on using the [**Number...
@ARWNightingale @vgomez-el cc @dplumlee Here are the credentials so that you can access ESS and Serverless environments for testing: **ESS:** Env Url: https://kibana-pr-179680.kb.us-west2.gcp.elastic-cloud.com:9243/ User and password: https://p.elstc.co/paste/s7aUuzef#3dFyPMsGXJ50ecNnK5kDBUkiy3CGEOV8JQ+UJN6P5Dx **Serverless:** Env URL:...
Agree with @ARWNightingale comment above, but I think the validation should fail on the API request, same as when the the value is negative. Left a [comment in the PR](https://github.com/elastic/kibana/pull/179680/files#r1589048704)...
@approksiu @ARWNightingale > Is it possible to use the fields drop-down component for adding required fields? Yes, we have to think about the design here. The `required_fields` field looks something...
@approksiu @ARWNightingale I checked how the Alert Suppression component works, and we can reuse that functionality. Basically, we call the `[useRuleIndexPattern](https://github.com/elastic/kibana/blob/main/x-pack/plugins/security_solution/public/detection_engine/rule_creation_ui/pages/form.tsx#L128)` hook to retrieve the list of fields, and the...
> I assume if one type option is available - it will be automatically selected for the user. Yes, once the user chooses a required field, let's preselect the first...
@nikitaindik Finished [exploratory testing](https://github.com/elastic/kibana/pull/180682#issuecomment-2115450183), looking good! Great work 👍 Also, thanks for the super detailed PR description.