Juan Pablo Djeredjian

Results 28 comments of Juan Pablo Djeredjian

@jethr0null @banderror One additional thing to take into account is that, if we remove the `Perform no actions` option from the throttle dropdown for bulk rule actions, then we also...

## Can we remove `muteAll` related code from our create and update rule endpoints? ### CREATING A RULE We don’t seem to need to mute the rule on creation: the...

@banderror ### Alternative 1 It looks I've found the reason why `muteAll` had to be used as a "workaround" for effectively stopping actions from being executed: with the current implementation,...

@banderror Had a call with @XavierM today and discussed the possibility of working on Alternative 1, setting `notifyWhen` to `null` and having that prevent the actions from being sent by...

@joepeeples @banderror This PR introduces changes to the Bulk Editing of Rule Actions that might need some updating of docs to what was already discussed in the PR that added...

Decisions taken on sync with @banderror and @xcrzx : - Correct PR to reintroduce logic that unmutes rule when bulk actions are set (otherwise previously muted rules will not execute...

@banderror @xcrzx Tested locally correcting the logic so that the `notifyWhen` param can be set to `null` [instead of being corrected to `onActiveAlert`.](https://github.com/elastic/kibana/blob/main/x-pack/plugins/alerting/server/lib/get_rule_notify_when_type.ts#L15) A rule with the following params: ```...

Thanks for the review @banderror . Addressed your comments and rebased. The bug you mentioned above (the UI displaying "Perform No Actions" even if there are actions for the rules)...

@ > I receive a Bag Request error when bulk adding actions: > > Screen.Recording.2022-09-23.at.12.04.08.mov > Error message: > > ``` > [request body]: Invalid value "edit" supplied to "action",Invalid...

For reviewers: please rebuild the packages if you pull the latest version, the latest changes edit the io-ts types in the packages. Otherwise requests will fail.