JP Camara
JP Camara
> move the test into rubyspec so it will be available for all implementations. Where do I move it to make it part of rubyspec?
Sorry - i've been away on vacation and I've had trouble getting JRuby setup on my personal laptop. ``` [INFO] JRuby Lib Setup .................................... FAILURE [ 12.328 s] [INFO] ------------------------------------------------------------------------...
@headius sorry it took so long! I think this was the primary issue https://github.com/jruby/jruby/commit/49ba0dfbc42978ff5a133da2762c500f7a8edb61 I'm gonna see if there are any additional specs I could write to verify the behavior
Ugh, wrong syntax for the spec in `spec/ruby/core/thread/wakeup_spec.rb`. I couldn't get those specs to run locally at first but I think I missed the docs on running specs here https://github.com/jruby/jruby/blob/master/BUILDING.md#setup-testing....
Ok, updated - `jruby spec/mspec/bin/mspec ci spec/ruby/core/thread/wakeup_spec.rb` is passing locally
I also didn't know what would be a valuable extra spec to add. The `test_run_wakes_sleeping_thread` spec handles the problem nicely. Still isn't ideal that it's the one spec that caught...
@headius I see a few failures, but I don't think they're related to my code. You'd know best. If somehow I broke those, I just don't know at this point...
I'll give this a go!
Here's my first stab at it: https://github.com/jruby/jruby/pull/8332
@olleolleolle @eregon I removed the docs instead of updating them and squashed the commit