JP Camara
JP Camara
Any chance you could weigh in on the approach @byroot? In terms of the need to manually `free`, I've started trying to use TypedData_Make_Struct, but don't have it fully working...
> I haven't reviewed too deeply, but the changes overall make sense to me. > > > > For a sec I was worried the state allocation in the callback...
> Hey! > > > > First of all, big thanks for working on this! And for the patience with my sloooow review haha >_> > > > > >...
Closing in favor of https://github.com/ivoanjo/gvl-tracing/pull/18
> FYI @jpcamara Thanks @byroot, should be a helpful learning experience going through the struct code 👍🏼 . I've found a couple issues trying it out - i'll post some...
Once finished, this handles `Add support for producing data in a format readable by the [Firefox Profiler](https://profiler.firefox.com/) or [Speedscope](https://www.speedscope.app/)` here https://github.com/ivoanjo/gvl-tracing/issues/13
Hi there 🙋🏻♂️! I'll be submitting some PRs to: - Add some specs - Attempt Firefox profiler support (it's a little tricky but I do have it loading in the...
> THAT IS AMAZING AND I CAN'T WAIT! > > I'll add the caveat that I moved houses the past weekend and I may take a bit to review stuff,...
First PR for specs, including a bug fix for the block form of `start`: https://github.com/ivoanjo/gvl-tracing/pull/15 🎉. It only covers Ruby 3.2 atm, Ruby 3.3 will be upcoming.
I haven't lost sight of the 3.3 updates btw! I'm finishing up some work on MN thread support for Mac in Ruby (https://github.com/ruby/ruby/pull/9178) then I'll open a 3.3 PR here