Jan Buecken

Results 44 comments of Jan Buecken

> vcd_vapp_vm.name.id (which point to servername and not vcd id, I will open a separate case for this) https://github.com/terraform-providers/terraform-provider-vcd/issues/410

For reference: Issue detected during tests for https://github.com/terraform-providers/terraform-provider-vcd/pull/412#issuecomment-572471499

This will also resolve a statement from hashicorp in the documentation about depends_on: ~~~ The depends_on argument should be used only as a last resort. ~~~ https://www.terraform.io/docs/configuration/resources.html#depends_on-explicit-resource-dependencies Since the reference...

> Thank you for a good write-up. Would you update the links to PR to the exact place with relevant comments? As you know, that PR is huge. This will...

> Removing reference by name, however, is not recommendable, as it makes the system harder to use. > > I propose adding support for ID-based references, but leaving names in...

One additional comment: This is why data sources are important in other clouds: As a user, you usually work with the name. So you use data source to get id....

> We wanted and considered disk management in VM This is a bad idea to do this for all disks. Otherwise you run into issues like https://github.com/terraform-providers/terraform-provider-vcd/pull/441#issuecomment-584206258 In above case,...

> it allows to have multiple disks and there isn't a way to tell which is boost disk from template perspective You already match the disk by bus_type, bus_number and...

> > > Also we won't be able to track if someone made change in UI and terraform will try to fix changes - by recreating disks and no one...

I would like to complement my last comment https://github.com/terraform-providers/terraform-provider-vcd/issues/519#issuecomment-651060413 For every resource, you have to implement **CURD**: **Create** API Calls to create the resource **Update** API Calls to apply changes...