jpatra72
jpatra72
Hi @nate-wandb, ```wand.run``` is ```None``` at the start of the second run. Edit: I also thought that the cause of the issue maybe because the patch applied to ```gym.wrappers.monitoring.video_recorder.close()``` by...
hey @nate-wandb, were you able to have a look at the issue yet?
Hi @nate-wandb, the workaround does seem to be working. Do I now close this issue or wait for a more permanent fix?
Hi @anakin87 , I have made a PR for the zero-shot document classifier. Let me know if you find anything missing in the implementation. :)
@shadeMe , no problem! I think the issue was that the licence info was missing in the scripts. I have fixed it now.
@shadeMe, the pr now passes all the git checks!
Hi @dfokina , your suggestions seem very valid. I have incorporated all of them (Y)
@shadeMe , any idea why the unit test fails here - [check results](https://github.com/deepset-ai/haystack/actions/runs/10725494109) ? The fail test refers to the following line - [Link](https://github.com/jpatra72/haystack/blob/b2f901cf4825d16bd3e9881d010455d84440b2c6/test/components/classifiers/test_zero_shot_document_classifier.py#L24) I did not run into this...
@shadeMe , I was referring to the failures in the following test - [Link](https://github.com/deepset-ai/haystack/actions/runs/10725494109). This was before i made some mods to the doc strings based on dfokina's feedback. I...