Joost Pastoor comments

Results 19 comments of


                                            Joost Pastoor

Prevent panic when batchFunc returns nil in his results

In the case that the batchFuncs actually misses keys (and length of result is different than the length of keys) the dataloader injects errors for the thunk() method to read...

Hystrix Metrics Collector for Expvar backend

Travis Error seems unrelated to my patch.

Release PHP 7.4 Fix

@mk-j Thanks for making the release in github. Could you also update it at packagist? packagist.org/packages/mk-j/php_xlsxwriter

Methods with local caches will not play nice with api response of false

Agree if you are suggesting that we might want to refactor the code to throw an exception in case of failure, and remove the boolean "false" response case altogether from...

Suggestion to remove support for PHP 5.3 for 2.0 release

Still think its a good idea. The people running old and EOL PHP versions are most likely not our customer base doing fancy stuff with composer/github.

Api methods now consistently return as associative arrays instead of Result (BC warning)

Still WIP, a few more tests are in the pipeline.

Api methods now consistently return as associative arrays instead of Result (BC warning)

Thats it for me for now, rest of the tests can be done in a later PR, maybe even by someone else. (Improved Api class line coverage from 38% to...

Api methods now consistently return as associative arrays instead of Result (BC warning)

Hard for me to spent time on atm, will have more time in october to finish this and some other stuff :)

Api methods now consistently return as associative arrays instead of Result (BC warning)

Sweet, done

Renaming and expanding on the getRoles methods

Already written the code but leaving it open for discussion first ``` /** * Returns all roles. * * @return array|false */ public function getProjectRoles() { return $this->api(self::REQUEST_GET, '/rest/api/2/role'); }...