jp-rad

Results 7 comments of jp-rad

Change the `loadedmetadata` event to the `playing` event, and then get around it for now. But no autoplay. https://github.com/mediacms-io/mediacms/blob/main/frontend/src/static/js/components/video-player/VideoPlayer.jsx#L195

Time setting is held off until a `canplay` event occurs, `function currentTime`. [v1.8 - 7.20.2](https://github.com/mediacms-io/mediacms/tree/1ddfae7c956e6d3c70a026847a5606ccf8638d10/frontend/src/static/lib/video-js/7.7.5) video.js (L.L.25427-25456) ``` video.js /** * Get or set the current time (in seconds) *...

Change the `loadedmetadata` event to the `canplaythrough` event that occurs after the `canplay` event https://github.com/mediacms-io/mediacms/blob/main/frontend/src/static/js/components/video-player/VideoPlayer.jsx#L195 ``` player.player.one('canplaythrough', () => { const urlParams = new URLSearchParams(window.location.search); const paramT = Number(urlParams.get('t')); const...

`setTimestampAnchorsAndMarkers()` and `initialize()` are called on the `loadedmetadata` event, and thus the order of their execution is undefined. `setTimestampAnchorsAndMarkers()` https://github.com/mediacms-io/mediacms/blob/main/frontend/src/static/js/components/comments/Comments.jsx#L447 `initialize()` https://github.com/mediacms-io/mediacms/blob/main/frontend/src/static/js/components/comments/videojs-markers.js#L454

`setTimestampAnchorsAndMarkers()` is only called on the `loadedmetadata` event, so adding or removing comments during video playback will not change the timebar markers. https://github.com/mediacms-io/mediacms/blob/main/frontend/src/static/js/components/comments/Comments.jsx#L447

Pull Requested, https://github.com/mediacms-io/mediacms/pull/706 However, there is a problem with the following: the comment does not appear on the video. 1. upload videos 2. Add a timed comment to each video...