Joshua

Results 27 comments of Joshua

In that case it would be good to update the reactnative.directory metadata for this package (https://reactnative.directory/?search=react-native-zip-archive) so that Expo doesn't warn about it, seeing as it has been tested to...

This increases readability and maintainability of the code, but certainly does not "optimize" the algorithm, for you have added the extra overhead of calling a function, which will actually slow...

@ivanz851 Thanks, I learned something new today. Cheers

Hi @kdewald, I repeated the test with the new commit/release, but got the exact same result as above, with no extra logging... ```python import simplepyble def main(): print("SimpleBle version:", simplepyble.get_simpleble_version())...

Patch: `react-native-ble-plx+3.5.0.patch` ```patch diff --git a/node_modules/react-native-ble-plx/android/src/main/java/com/bleplx/BlePlxModule.java b/node_modules/react-native-ble-plx/android/src/main/java/com/bleplx/BlePlxModule.java index c731640..22b438d 100644 --- a/node_modules/react-native-ble-plx/android/src/main/java/com/bleplx/BlePlxModule.java +++ b/node_modules/react-native-ble-plx/android/src/main/java/com/bleplx/BlePlxModule.java @@ -788,7 +788,7 @@ public class BlePlxModule extends ReactContextBaseJavaModule { }, new OnErrorCallback() { @Override public...

I'm very thankful for this package and all the maintainers over the years, but I think it might be time to create a fork if it is going to remain...

Looks like you're using the same ID for the service and the characteristic. Nevermind, one digit is different.