react-native-zip-archive
react-native-zip-archive copied to clipboard
mockingbot
React Native Zip Archive - Migration to New Architecture
Description
When running the command:
eas build --local --platform android --profile preview
I encountered the following warning:
[RUN_EXPO_DOCTOR] Advice: Use 'npx expo install --check' to review and upgrade your dependencies.
[RUN_EXPO_DOCTOR] The following issues were found when validating your dependencies against React Native Directory:
[RUN_EXPO_DOCTOR] Untested on New Architecture: react-native-zip-archive
Temporary Solution
As a temporary workaround, based on https://docs.expo.dev/guides/new-architecture/#third-party-libraries-and-the-new-architecture I added the following configuration to my package.json:
"expo": {
"doctor": {
"reactNativeDirectoryCheck": {
"exclude": ["react-native-zip-archive"],
"listUnknownPackages": false
}
}
}
This change suppresses the warning, but it is not a long-term solution.
Request for Migration
A better approach would be to migrate react-native-zip-archive to the New Architecture. Migrating Your React Native Library to the New Architecture.
Thank you for the feedback. I completely agree that upgrading to a new architecture is essential, and I believe AI tools can significantly ease the process.
It would be super useful also for us to have this library ported to the new Arch! Unfortunately I dont have experience with porting RN libraries but if I can contribute in some way let me know!
@elsa17z @KristianLentino99 unfortunately, I haven’t started on this yet—any contributions would be very much appreciated!
@plrthink react-native-iap seems to want to migrate to Expo modules and keeping the old react-native-iap for old arch only. Should we do the same thing? Or perhaps use nitro modules. Nitro modules is much faster than turbo modules and turbo modules is faster than expo modules but expo modules has the simplest syntax. https://github.com/mrousavy/NitroBenchmarks
@plrthink react-native-iap seems to want to migrate to Expo modules and keeping the old react-native-iap for old arch only. Should we do the same thing? Or perhaps use nitro modules. Nitro modules is much faster than turbo modules and turbo modules is faster than expo modules but expo modules has the simplest syntax. https://github.com/mrousavy/NitroBenchmarks
Yep expo vs turbo modules are good questions. Off topic but good comment from creator of nitro https://github.com/lynx-family/lynx/discussions/1#discussioncomment-12660498
Most importantly what @mockingbot thinks? He is author at the end of the day...
one up for doing this in nitro modules. I think its the simplest path forward here
@sultanmyrza Were you building and testing your app with the New Architecture enabled?
@sultanmyrza Were you building and testing your app with the New Architecture enabled?
New architecture
In that case it would be good to update the reactnative.directory metadata for this package (https://reactnative.directory/?search=react-native-zip-archive) so that Expo doesn't warn about it, seeing as it has been tested to work with the New Architecture enabled (even though not migrated itself).