josie
josie
Echoing others, I like option 2 (side-binaries). A `bitcoin ` wrapper on top of multiple binaries also seems quite nice. While this might cause some confusion for end users, I...
Concept ACK > A notable use-case for the kernel library is accessing and analyzing existing block data A concrete example is index building in electrs / esplora / etc. For...
crACK https://github.com/bitcoin/bitcoin/commit/e9d60af9889c12b4d427adefa53fd234e417f8f6 Came here from reviewing https://github.com/bitcoin/bitcoin/pull/30965#discussion_r1776649353, haven't tested but did review and the code change is relatively straightforward (mostly a move-only change) and definitely improves the readability here.
crACK https://github.com/bitcoin/bitcoin/commit/60ade81516d42d275c1143f49f47e142d32c45fc Verified that the change is mostly move-only. Makes the code much more clear and cleanly separates initialising / opening the database from loading the database contents into the...
> Wait, how does pausing IDB help with benchmarking IBD? I had a chat with @Sjors recently regarding a benchmarking use case I have, where I want to benchmark doing...
I think this highlights a clear advantage of having a more "generic" mining interface exposed over an IPC interface: different mining protocols can use the same interface from Bitcoin Core,...
Looks like the most recent change is causing a failure in the unit tests: > 2025-07-22T13:09:52.932304Z (mocktime: 2020-08-31T15:34:12Z) [test] [txmempool.cpp:699] [void CTxMemPool::check(const CCoinsViewCache &, int64_t) const] [mempwallet/spend.cpp:1343 CreateTransactionInternal: Assertion `!change_script.empty()'...
> The current failing CI Should be fixed in my (just now) pushed changes for the base and sending PRs.
Rebased the base and sending PRs on master and fixed the static assert failure. Rebasing this on the sending PR should fix the CI failure.
> It's uncommon ~~I assume you are using uncommon here to mean "the class of errors that this protects against are uncommon errors."~~ EDIT: uncommon in the sense that using...