josie

> Hey @josibake, why doesn't the scanning algorithm just keep looking for labels until it hits a point where there are no more payments? Like going through from m =...

Updated https://github.com/bitcoin/bips/commit/f0625f73c08030293da925090cfbe9a927980dd5 -> https://github.com/bitcoin/bips/commit/901d41fc10f66d73a17581344b4646e981a52910 ([compare](https://github.com/bitcoin/bips/compare/f0625f73c08030293da925090cfbe9a927980dd5..901d41fc10f66d73a17581344b4646e981a52910)) * Split BIP text and testing vectors into two commits. I expect fewer changes to the BIP text going forward and most changes (if any)...

Updated https://github.com/bitcoin/bips/commit/901d41fc10f66d73a17581344b4646e981a52910 -> https://github.com/bitcoin/bips/commit/b3495171054784d100b1a90addef463b61c9149c ([compare](https://github.com/bitcoin/bips/compare/901d41fc10f66d73a17581344b4646e981a52910..b3495171054784d100b1a90addef463b61c9149c)) * Updated "Test vectors" section * Updated test vectors, reference.py to match vin structured is in bitcoin core rpcs

Updated https://github.com/bitcoin/bips/commit/b3495171054784d100b1a90addef463b61c9149c -> https://github.com/bitcoin/bips/commit/d73e924a5b1e43f0e5736d568097aa9a0b8cb210 ([compare](https://github.com/bitcoin/bips/compare/b3495171054784d100b1a90addef463b61c9149c..d73e924a5b1e43f0e5736d568097aa9a0b8cb210)) * Updated reference.py to check for compressed keys (per the updates to the BIP) * Code cleanup for reference.py (mainly adding a bitcoin_utils.py for non-silent...

Updated https://github.com/bitcoin/bips/commit/d73e924a5b1e43f0e5736d568097aa9a0b8cb210 -> https://github.com/bitcoin/bips/commit/55b05c68b04d486868c90d6b372a2ac8ff8f3f79 ([compare](https://github.com/bitcoin/bips/compare/d73e924a5b1e43f0e5736d568097aa9a0b8cb210..55b05c68b04d486868c90d6b372a2ac8ff8f3f79)) * Small fixups (wording/spelling) * Removed unused function from `reference.py`

Addressed all the outstanding feedback (let me know if I missed anything!). @RubenSomsen and I have also done a final round of review and are considering the protocol final. @luke-jr...

Updated https://github.com/bitcoin/bips/pull/1458/commits/55b05c68b04d486868c90d6b372a2ac8ff8f3f79 -> https://github.com/bitcoin/bips/pull/1458/commits/a2b52fea2538f106d13098c4efde016baf72052a ([compare](https://github.com/bitcoin/bips/compare/55b05c68b04d486868c90d6b372a2ac8ff8f3f79..a2b52fea2538f106d13098c4efde016baf72052a)) * Fixed spelling errors / improved wording (h/t @vostrnad) * Removed unused import from `reference.py` (h/t @theStack) Thanks for the thorough @vostrnad and @theStack, much...

Concept ACK Also an implicit approach ACK despite not heavily reviewing the code (yet). I have been focusing on using the kernel library in proof of concept applications to get...

Thanks for starting this! Will review. Just wanted to comment that I've made a round of edits to the BIP and it is now updated with the new hashing method...

> but then we would need to pass the input pubkeys and calculate the pubkey sum twice (I need to actually review your implementation, but..) I don't think we need...