Joshua Pinter

Results 159 comments of Joshua Pinter

Are you able to dig into this and see what's going on? Seems like a good first issue to fix.

Thanks for bringing this up, @joonhocho! I tested it against 5000 contacts and it didn't seem to be an issue but it's a good idea to make it optional. I'll...

Hi @elliotfleming! Thanks for your comment. I haven't run into this issue myself but I think adding container support makes a lot of sense. I'm not in a position to...

Absolutely. I've been making improvements to Android recently, including [SelectContact](https://github.com/joshuapinter/react-native-unified-contacts#select-a-single-contact), which is really slick. The more I think about testing, the more I think that Jest and Enzyme won't cut...

I think the two obvious ones are CircleCI and Travis CI. Here is an example CircleCI project for React Native: https://github.com/CircleCI-Public/circleci-demo-react-native Might be a good starting place. Plus, they offer...

Sounds good. Well, I'll get things setup and get the first couple tests done so that there is a pattern and let you finish it off from there.

Started playing around with this on the tests branch: https://github.com/joshuapinter/react-native-unified-contacts/tree/tests Much more difficult than anticipated. Will require a whole weekend to get this working right so have to put this...

Not sure. This library was built with English only in mind. Happy to accept a PR that adds internationalization support. On Dec 1, 2020, 6:02 AM -0700, ShrutiGarg019 , wrote:...

Wow, this looks like a great update. Thanks! Since it's such a big change, I'd like to get some tests in there before merging. Any chance you can write some...

@jyliang Awesome, and likewise!!