react-native-unified-contacts icon indicating copy to clipboard operation
react-native-unified-contacts copied to clipboard

Published 20 hours ago • verified publisher icon joshuapinter

Adds support for field filtering.

Open jyliang opened this issue 6 years ago • 5 comments

jyliang avatar Dec 23 '17 06:12 jyliang

Wow, this looks like a great update. Thanks!

Since it's such a big change, I'd like to get some tests in there before merging. Any chance you can write some basics tests for those new methods?

joshuapinter avatar Dec 23 '17 16:12 joshuapinter

cool, i'll try to get some in after the holidays. happy holidays btw!

jyliang avatar Dec 24 '17 16:12 jyliang

@jyliang Awesome, and likewise!!

joshuapinter avatar Dec 24 '17 18:12 joshuapinter

Hey @jyliang this feature is exciting. Are you able to bring in some of the more recent changes from the master branch since your PR and then thoroughly test it? Would love to see this merge.

Also, we've updated the Android branch, so this feature would be a good one to also have over there as we're starting to get to a point where we can bring Android support to master.

paintedbicycle avatar Mar 22 '18 08:03 paintedbicycle

Was just about to ask about this functionality. Nice work @jyliang although its almost a year old now heh

bradennapier avatar Nov 09 '18 03:11 bradennapier