Josh Moore

Results 1011 comments of Josh Moore

I was thinking merging @grlee77's PR would clear up your mypy woes, @d-v-b, but there look to be a few more.

Hi @brentp. Which cells are you expecting to receive? e.g. ``` In [1]: import zarr, numpy as np In [2]: z = zarr.array(np.arange(20).reshape(10,2)) In [3]: z[:] Out[3]: array([[ 0, 1],...

Ah, I see. I remember there being limitations but I don't remember this one. @jni?

`z.oindex[rows]` certainly returns the same values, but `vindex` is being used by `z[rows]`.

Sorry, I failed to note that no one else has responded. I'm all for incremental steps, but maybe there's a question of how to document the rest of the steps...

Having apparently killed the conversation, I'm inclined to say, "Go for it, @jni! 👏🏽"

Still an issue? And with @d-v-b's new version?

Hey @oeway. Thanks for the suggestion! In your mind is what we need the addition of an optional argument for `path`? Seems like the only possible downside of that would...

I wouldn't suggest renaming since existing code could be using `ZipStore(path=)`. If permitting a FileLike for something named "path" is too confusing, then perhaps we add a static initializer `ZipStore.from_file(file,...

Issue created, @jakirkham. > Think it would be ok to just accept `ZipFile` instances in `path`. So the logic would be: * is_zip_file() * is_file_like() * is_path_or_string_like() Or would you...