Josh Lory
Josh Lory
Re-opening bugs that missed the ship bar for HoC 2017.
Similar issue with entities and blocks to the east and west: 
Re-opening bugs that missed the ship bar for HoC 2017.
 [Update Blockly build to use JS closure compiler, or webpack 4](https://trello.com/c/DAFlITFa/127-update-blockly-build-to-use-js-closure-compiler-or-webpack-4)
@Hamms we didn't end up switching to the non-Java version of Closure Compiler, but I think this PR covers a lot of the build improvements: https://github.com/code-dot-org/blockly/pull/135.
Might be fixed by https://github.com/matt-kempster/m2c/pull/235?
There are a few in [weapon funcs](https://github.com/search?q=repo%3AXeeynamo%2Fsotn-decomp%20*prim%20%3D%20*prevPrim%3B&type=code), links below. https://decomp.me/scratch/udWNi ``` 2ac: move a2,s0 2b0: lw t0,0(s0) 2b4: ~> lw v0,0(a3) 2b8: lw v1,4(a3) 2bc: lw a0,8(a3) 2c0: lw a1,0xc(a3)...
Slightly different pattern here: https://decomp.me/scratch/ra0BJ ```asm c: addiu a3,sp,0x10 10: lui a2,%hi(g_Entities) 14: addiu a2,a2,%lo(g_Entities) 18: addiu t0,a2,0xb0 2c: ~> lw v0,0(a2) 30: lw v1,4(a2) 34: lw a0,8(a2) 38: lw...
FWIW this only seems to happen after enabling the wasm module. I was getting this hang regularly with it enabled, and never since disabling it.
Nice cleanup!