Josh Heald

Upgrade Swiftlint to 0.41.0

1

Closes: #3173 ### Description Updates SwiftLint so that we can remove the non-inclusive language from the project, and use `only_rules` instead. ### Testing instructions Lint runs successfully with `bundle exec...

⛔️ Awaiting design confirmation: p91TBi-8P0-p2#comment-10438 Refunded shipping is not displayed anywhere on the Order Details screen, nor in the refund details that you can tap through to. > There’s an...

⛔ This is awaiting design work from @joe-keenan >  > > Now, if all products are refunded, the action buttons are hidden. But the action buttons affect the entire...

[Mobile Payments] Onboarding is run for every payment when a reader is connected

1

## Description While working on #7504, I noticed that we run the IPP Onboarding flow every time we tap `Card` on the Payment Method selection screen. Onboarding flows are only...

[Tablet Orders] Make order sync blocking in side-by-side mode to improve product selection sync reliability

1

Part of: #11908 ## Description This isn't pretty. With the side-by-side order creation process, we sync product selections and removals as soon as they are performed. This makes it easy...

Potential approaches: - Block product selection during "major updates" (current approach, inheirited from iPhone) - Block product selection for every update (should be reliable, but quite frustrating to use. Probably...

## Description Previously, we ignored `transaction_reason_invalid` errors from the MobilePay API. We ignored them because usually they were the result of submitting a `RENEWAL` transaction to the `/iap/orders` endpoint, when...

Repro: On an iPad, using a store with tax rates set up 1. Tap `Orders` 2. Tap `Create` 3. Add a taxable product 4. Expand the totals drawer 5. Tap...

[Tablet Orders] Scan to Pay window is very wide when presented on an iPad

1

 ## Repro 1. Launch the app on an iPad. 2. Tap `Orders`. 3. Select an unpaid order, or create a new order with a product. 4. Tap `Collect Payment`....