Josh Elser

Results 51 comments of Josh Elser

Jacques mentioned that he wanted to take a look at this change, so I've tagged him for review.

FWIW, there wasn't much in terms of python tests we added that weren't already encapsulated in the label test cases (largely, because we didn't write pytests that required Snowflake --...

Pushed a few commits: * `admin.write(..)` now incrementally builds up the "pieces" from the incoming `object`, to then combine into the skeleton of the `MERGE` statement. This is much more...

@rymurr feedback from friday. Notably, I dropped grouped and dynamic label stuff from the current PR to reduce the size of it. One addition that we didn't discuss was that...

> Any comments on time and improvements? Yeesh, we took a step backwards for ungrouped label creation `ADMIN.CREATE_LABEL()` is taking ~6s. Of that, the current breakdown is: * `admin.validate` takes...

> I'll re-evaluate with a hybrid table in a moment Making `internal.labels` a hybrid table with `label_id primary key` drops the execution time of the `MERGE` statement inside `admin.write` from...

> I think we should be able to make all validation a single SQL select query. Prove me wrong :D I just pushed the latest (which has grouped and ungrouped...

> Maybe an unpopular opinion: should we give this up and just go back to V1 of these? V1 beign specialized procedures for each crud type? I had the same...

@anshuldata we used to create Github issues for work we were going to do but have lately stopped doing that. You can just track work for OpsCenter in our (private)...

I assume it's a non-starter to push the qtag unwrapping into a downstream view, e.g. `REPORTING.QTAGGED_QUERY_HISTORY`? Assuming it's a non-starter, pushing into the MV seems much better but I am...