Josh Elser

Left a few comments for you inline. Overall, I like the changes. Would love to see corresponding ones made for sqlline.py initially (we tend to make changes to one in...

> quite a bit of this script is to poke the environment .. which is I/O. Unit testing may not yield much. But, i'll take a fresh look. Yeah, I...

> I have added what I think is cross-platform way of handling zombie? child processes. *nux is definitely the one we care about the most :). I would expect that...

Sorry for the delay @btbytes, I missed your latest push where you addressed sqlline.py too. Thanks! I think this is looking good. I left one comment for you. I will...

Alright, I'll try to poke at this one today.

``` % ./bin/sqlline.py Traceback (most recent call last): File "./bin/sqlline.py", line 139, in main() File "./bin/sqlline.py", line 132, in main preexec_fn=os.setsid) File "/usr/local/Cellar/python/2.7.12/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 711, in __init__ errread, errwrite) File...

re-ping @btbytes :). Still looking at finishing this up? It would be a very nice improvement for 4.9.0.

No worries! Just cleaning up my inbox and thought about it again. Thank you for returning to it :)

> I could not set the configuration of phoenix, so I'v tired to add the code to solve this problem. What were your steps to set these configuration properties before...

Non-scientific results show create label latency on the low end around 500ms and on the upper end around 2.5s. I would imagine we can chop some of that off by...