Josh Leonard

Results 12 comments of Josh Leonard

Taking a look at the crashing issue now.

I tried recreating this by resetting the wallet and onboarding a second time while recording. No crash here on M1 mac. https://user-images.githubusercontent.com/30185185/183713843-b697abaf-64e0-41d9-b671-d1720fb8ee6c.mov

> From a security perspective, could be good to refactor that maxAttempts number to be set once by the function rather than by the caller, but that's non blocking and...

> > I tried recreating this by resetting the wallet and onboarding a second time while recording. No crash here on M1 mac. > > Screen.Recording.2022-08-09.at.11.04.03.AM.mov > > 👍🏻 I'll...

@fmarier, has [zxcvbn](https://github.com/dropbox/zxcvbn) already been formally audited by the security team or do we need to request one?

> same question as @petemill - and please pin the exact library version in package.json Pinned to exact version. Adding this dep in a separate PR so I could get...

Requesting re-review from @petemill & @diracdeltas, I have added some code that utilizes Redux Toolkit.

@wolbek, would you please squash this PR down to one commit?

Yes @wolbek, I will merge this when all CI checks pass. Thanks for your contribution

Closing. Loading numerous iFrames had a noticeable performance impact