Josh Betz

Fixed the issues flagged by @walterebert here: https://github.com/WordPress/two-factor/tree/dxw-feature/generate-qr-internally. @kasparsd Do you think we should commit the library directly here or add to composer?

> However, it has been like that for the past four years [b5df9ba](https://github.com/georgestephanis/two-factor/commit/b5df9bac4e1c255c661407eb70568ad141df6bda) and it could introduce a regression if we change it right now. In most cases the `home_url()`...

Since it looks like you can pass in values to the fields that don't save as arrays, this would only effect multi_select, taxonomy_checkbox, and taxonomy_multi_select. By default, these all use...

It gives you more control. Instead of choosing between slug and ID, you can make the value whatever you want. It's also not ideal to add more parameters.

I was thinking this would literally be [a filter](http://codex.wordpress.org/Function_Reference/apply_filters). I've added some more details to the issue (#98).

:+1:

> If we go with the "matching wpcom" we can go up to 5.5 There are still some 5.4 servers.

> some checks (especially some regular expressions) are currently just insufficient, either missing dangerous stuff, or producing false positives. Because of the way we use the scanner, false positives are...

> I am getting an error with my current code. > Parse error: syntax error, unexpected '(', expecting ',' or ';' in /wp-content/plugins/vip-scanner/vip-scanner/class-base-check.php on line 8 You can't call a...

I kind of think this should be a note. There are legitimate cases where someone would use `site_url()`.