Josh Alling

Results 10 comments of Josh Alling

@PsidomPC I ran into the same error when I ran `yarn build`. It seems to be a problem specific to the ember framework. You can still run `yarn start` and...

I would also like to see this feature added and would be willing to submit a PR for it if approved.

@web2033 Thanks for that article. It looks like pretty much all use cases for `componentWillMount` can be migrated using `constructor` or `componentDidMount`. Maybe in the first challenge we could have...

I just think that allowing a solution like this teaches a bad practice as it only works correctly if the array passed has exactly three values. What if your failures...

We should add the new lifecycle methods and remove the deprecated ones based on the react docs [here](https://reactjs.org/docs/react-component.html#the-component-lifecycle). It also looks like much of the updating challenges ([here](https://learn.freecodecamp.org/front-end-libraries/react/manage-updates-with-lifecycle-methods) and [here](https://learn.freecodecamp.org/front-end-libraries/react/optimize-re-renders-with-shouldcomponentupdate))...

@kevinsmithwebdev I think you are right about not removing them completely. It would be good to mention them, explain that they have been deprecated as of react 16.3, and include...

@RobAnthony01 I don't know if we want to get so specific in our tests that we are requiring a comment in the solution. In the future, if the challenge changes...

@RobAnthony01 I get where you are coming from, but in my mind this is just one of the caveats of using regex. We can't prevent all these edge cases unless...

@scissorsneedfoodtoo There is one potential problem with that solution, and it's that the solutions would all have to be removed as jQuery isn't included in the test suite. For that...

@RobAnthony01 Your right. We would need to change all the solutions that way too. I thought that there were already spaces there. The only reason I suggested that is because...