Bean

Results 34 comments of Bean

@Ansonhkg would we be able to update the `e2e` nodejs tests? when i go to use the `1-sig` lit action test the following errror is returned ``` [Lit-JS-SDK v5.0.0] [2024-05-01T21:14:02.577Z]...

> @Ansonhkg would we be able to update the `e2e` nodejs tests? when i go to use the `1-sig` lit action test the following errror is returned > > ```...

@sobebarali yes you may! I will Assign it.

> @joshLong145 I see you commented yesterday but removed your comment again. Any thoughts on this? I took your advice and removed all my logic for managing controllers and went...

> I was looking into this in more depth, and noticed that the `onTerminate` option is _really_ close to what we're looking for here for this `onAbort`. So much in...

> Sorry about the confusion about `worker`. What I meant was `workerpool`, the imported library. So it would be an overwritable function of the library, `workerpool.onAbort = ...`, similar to...

> Do you have thoughts on how to best expose the `onAbort` function? Like `workerpool.onAbort = ...` or `workerpool.addAbortListener(...)`? I have the feeling that the latter is most neat and...

> > Do you have thoughts on how to best expose the `onAbort` function? Like `workerpool.onAbort = ...` or `workerpool.addAbortListener(...)`? I have the feeling that the latter is most neat...

@josdejong @wmertens PR has been updated with - New `finally` implementation - Method documentation in README - Test case additions to `Promise.test.js`