Joshua Ruehlig
Joshua Ruehlig
I recommend you guys stop controlling sickbeard using wget. it responds correctly to the SIG-TERM that the freebsd rc.subr system uses. there is no need to write such complicated functions...
Do large downloads/uploads work on Apache without tweaking, or do you need to use tweaks from the "Uploading big files" page of the manual? Just trying to confirm why they...
Thanks for explaining my misunderstanding with `client_max_body_size` pertaining to uploads and not downloads. But my point is that I have none of these settings (so they would set to nginx...
@andrevanzuydam what OS are you using Git.php on? Do you mind testing it this change works/breaks anything for you?
your app can enable windows mode, or change the path. but by default we shouldn't be hardcoding this path.
I'm not sure, I haven't looked into this code for a while. but I do remember it is an option.
@kbjr Could Git.php instead use `protected static $bin = 'git';`? This way systems with proper PATH set for PHP would find git even if it isn't the currently hardcoded /usr/bin/php....
@kbjr thanks for the reply, that's what I figured based on the commit history. It looks like the hardcoded /usr/bin/git path has been there since the beginning. https://github.com/kbjr/Git.php/blob/f7c5235fef70ac75576a93842beb1f2f3175f66d/Git.php#L73 Maybe it...
@andrevanzuydam This would require Git.php have all the possible/common paths hardcoded. Or the program calling Git.php could have this logic instead. I'd personally prefer just calling 'git' and relying on...
My proposal is here https://github.com/kbjr/Git.php/pull/48