José Valim

Results 1849 comments of José Valim

The clients no longer talk to the server via epmd, they connect directly to the port. I think the server still tries to register itself in epmd (but I think...

That was a lie. I had to push one small change to the code above (now edited). Now it works. Here are the receipts. Save the `Expert.EPMD` above to `epmdless.ex`...

In practice, you only need to start the Expert server passing `-epmd_module Elixir.Expert.EPMD` in vm.args. The current implementation tries to register itself in epmd but, if it cannot find anything,...

Here is the updated version as required: ```elixir defmodule Expert.NodePortMapper do use GenServer @name __MODULE__ def start_link(_) do GenServer.start_link(__MODULE__, :ok, name: @name) end defp parent_node do if parent_node = System.get_env("EXPERT_PARENT_NODE")...

Hi @joshk!! We definitely want to do this but, because we cannot require v1.18 (it is too new), we need to depend on Jason anyway, so there isn't much benefit....

Optional dependencies are not installed by default, which means that if we make Jason optional, all projects that depend on `esbuild` today but do not also explicitly depend on `jason`,...

This is beautiful, thank you for working on it! :heart: The only other feedback I have, which we should explore in a separate pull request anyway, is to increase the...

Correct. transaction is checkout+begin+commit, but if you are only doing reads, you don't need begin+commit. :)

I have added `pool_count` support to EctoSQL v3.12.1+: https://github.com/elixir-ecto/ecto_sql/pull/636 My suggestion is that, once this PR is merged and we measure its new baseline, we should update `ecto_sql` and use...

@srcrip some numbers have come out for using transactions and it already does better, so I am sure we are in the right track: https://www.techempower.com/benchmarks/#section=test&runid=176ba510-3607-4faa-996e-74f0778b88d4&hw=ph&test=query Btw, it seems the plain...