José Valim

Results 1855 comments of José Valim

I believe the docs chunk will have markdown for Erlang from OTP 27 onwards if using `-doc`.

Hi @tmbb! I need to understand the problem a bit better. Why can't the associations be loaded before you put the data in the changeset? Can you provide a general...

Why can't you preload the associations into the struct before you call `cast`? You already have to load it from the database, why not preload it by then?

I think the simplest solution is to add a flag to cast_assoc that resets the association if unloaded?

We should not really preload it. The issue you describe is for new entries, so we should allow resetting it for new entries, and then we will be all good.

@greg-rychlewski I didn't check the code (sorry, I am being lazy) but would that only be invoked for new records? For updates it can lead to weird failures.

@tmbb, please feel free to explore the option to `cast_assoc` route above. We don't plan to move forward with the exact approach in this PR. Thank you!

> Right now the diagrams are dynamically rendered on the browser. This means you will just get the diagram source as raw text on the EPUB. I looked into this...

The script we have for Elixir handles color changes: https://github.com/elixir-lang/elixir/blob/main/lib/elixir/scripts/elixir_docs.exs#L191 - I believe it is the same suggested in ExDoc README.

> We just need to be vigilant that these types of diagrams don't end up in the function documentation as I'm guessing VS Code/Emacs/VIM also will have a hard time...