Joseph Guillaume

Results 141 comments of Joseph Guillaume

Limits the ability of hydromad to be used for calibration of more complex real-world cases common in other software. River routing capabilities would also be required.

Errors have been removed in #126, but still need to check whether links need to be added back in. A good starting point is https://github.com/josephguillaume/hydromad/pull/126/commits/2f5ee8605c85b3bafa36b5f7a48982473f040e4a

HBV also includes its own snow routine.

Apparently POSIXct is not a problem, though POSIXlt is In the reproducible example in https://groups.google.com/g/hydromad-users/c/sGdxOnlS5AU/m/716wTAxaBgAJ, it turns out the error was the inappropriate specification of frequency=24. Converting to chron was...

@jnothman - we might need some advice on how to deal with this one

Thanks! I'll have another look when the number of lintr warnings goes down. I assume there's a way of suppressing the lintr warning for a particular function if needed, with...

Could allow optional use of https://www.rdocumentation.org/packages/Evapotranspiration/versions/1.2

This would need some thinking. 1) It's possible it would be a complete change to the generic functions used in hydromad. One effort we need to check out is https://www.tidymodels.org/...

We need to consider what format to use for time series. This might include supporting multiple options: * Just a data.frame with a column called Date (used by hydrostats), but...

Open to suggestions here, though it will likely still be a collaborative effort