Results 56 comments of Joseph Frazier

Hi everyone, I just wanted to chime in with my current workaround, adapted from some comments above ([pscanf's](https://github.com/facebook/create-react-app/issues/2353#issuecomment-306863200) and [heyimalex's](https://github.com/facebook/create-react-app/issues/2353#issuecomment-306949558)): * Create `build-env.js` with the following contents: ```js // adapted...

For what it's worth, we had previously tried using a more robust bash parser, but we stopped after discovering potential licensing issues. See here for details: https://github.com/nvbn/thefuck/issues/589

> There is a feature request somewhere for an option to disable this and only use the AST, though. Here it is, for reference: https://github.com/prettier/prettier/issues/2068

Wow, that helps a lot! I'll see what I can do with it and submit a pull request if I get anywhere.

I... never actually started on this :/ Hope you weren't waiting long before asking about it.

Thanks for the quick feedback! I copied the `promise-each` implementation into `lib/promise-each.js`, modified it to remove dependencies and linting errors, and used it instead. What do you think?

Hey @simalexan, have you had a chance to review the most recent changes? I just stumbled across this again and thought I'd check in.

Note: this was reported in the Google Group: https://groups.google.com/forum/#!msg/sip_js/hzoMQ-xXIko/ZhTbocagi-oJ

Putting this on the back burner for now. Partial work has been pushed to [my sessiontimers branch](https://github.com/joseph-onsip/SIP.js/tree/sessiontimers), if anyone is interested in picking it up.

Hey @markandrus, sorry for the latency on this. I've created https://github.com/onsip/SIP.js/pull/203 on your behalf, so the changes can be considered there.