fson icon indicating copy to clipboard operation
fson copied to clipboard

Implement support for external Zofu

Open barracuda156 opened this issue 2 years ago • 3 comments

CMakeLists have the following: https://github.com/josephalevin/fson/blob/16731d9b510b94a4e074a1fa7e35706f6045a85f/CMakeLists.txt#L133 In fact, however, zofu does have CMake implementation. It is also desirable to add an option for using external zofu, so that it does not need to built twice. (Moreover, on macOS internal build of zofu just fails, at least on my system. External works perfectly and passes all tests.)

barracuda156 avatar Jan 07 '23 07:01 barracuda156

Yes, zofu does have a CMake implementation now, so that could probably be changed.

@kprussing, you did the CMake stuff for FSON, would you be interesting in looking into this?

acroucher avatar Jan 16 '23 02:01 acroucher

Besides, with meson everything worked fine with external zofu as is. Only CMake needs an option or a fix for it to work automatically.

barracuda156 avatar Jan 16 '23 07:01 barracuda156

I'm not 100% sure what is going on with the built version of ZOFU. I just tried a handful of times on macOS and had no trouble building. I'm using gfortran 12.2.0 from MacPorts.

kprussing avatar Jan 23 '23 17:01 kprussing