Josejulio Martínez
Josejulio Martínez
I created a PR to fix this issue, could you verify if that fixes your issue also? Not sure if we have to change any other getter.
Thanks, I probably modified something that didn't need to change. Could you send a g4 file that reproduces the issue?
I couldn't reproduce, i'm using typescript 4.0.2 and here is the output of the antlr4ts: https://gist.github.com/josejulio/8a7959ef6f7c646b88cd03bb24bf0ad6 Could you tell if is similar to the one you are getting? edit: Also,...
I might be approaching this bug on the wrong side. Looking more closely, https://github.com/tunnelvisionlabs/antlr4ts/blob/master/src/Recognizer.ts#L117 is implementing the `get` method, but typescript(?) might be generating a `readonly` definition, which is weird...
> typescript(?) might be generating a `readonly` definition Looks like that's the behavior on (and before) typescript 3.6.2 edit: Updating typescript to 3.7.5 on this project seems to resolve the...
Updated the PR. Now I'm upgrading to 4.0.2 and fixing a compile time error of the lib itself.
> I added this lib to our code recently and I'm seeing really poor performance when I have more than 50 nodes on the graph. After some profiling, I found...
That function gets called for the element every time there is a `style` or `data` update on the element. Do you make such changes by code? If so maybe you...
@stalniy Could you send a PR for this one too?
> @josejulio if you are OK with the proposed implementation, I'll send a PR It makes sense what you have there, please go ahead!