Josejulio Martínez

Results 44 comments of Josejulio Martínez

> It would be great if we'd be able to access builds from other repos in our org through this action. > Is that planned at all? This action doesn't...

I use this one to download artifacts from other repository: https://github.com/dawidd6/action-download-artifact Before that I used this script: https://github.com/RedHatInsights/policies-ui-frontend/blob/03870393c706db5d4f30d3708058bb3dd85241a2/.github/scripts/download-latest-openapi.sh

I hit a similar issue, but in my case `v` has a value, but `g.node(v)` returns undefined. ```javascript function assignOrder(g, layering) { _.forEach(layering, function(layer) { _.forEach(layer, function(v, i) { g.node(v).order...

@mmacfadden thanks to your reproducer and some guesswork i think i found out the problem. Let me explain, the problems seems to be related to the way `lodash` `forEach` works,...

@j6k4m8 can you take a look at https://github.com/dagrejs/dagre/issues/234#issuecomment-399488074? If what I say is correct and makes sense (if not, please let me know, thanks!), what do you think the best...

I tried with `forOwn` and `forIn` because i saw [lodash.forEach](https://lodash.com/docs/4.17.10#forEach) docs, but same results. > Note: As with other "Collections" methods, objects with a "length" property are iterated like arrays....

It seems that `util.buildLayerMatrix` is used elsewhere, so it would be better to fix up there.

I did something quick to remove the gaps and shifting the order, but other error appeared after that ``` Error: Not possible to find intersection inside of the rectangle at...

> It might be related to the lack of connected DAGs, however, I have several other instances of not-connected DAGs that work. In fact, in my reproducer, removing any one...

> @josejulio, just an aside, but as lovely as that graph looks using a directed algorithm like dagre (like a dragon!), using a spring/force algorithm like webcola or d3-force will...