Johannes Schmitt

Adjust indentation to two spaces

2

... since it was such a huge success in Nemo and there are not many (active) pull requests open right now. I can of course easily update this, if something...

Usability of non-standard index ranges in variables of polynomial rings

7

This came up in the discussion of #1360 ; requires either #1360 or Oscar: ``` julia> R, x = polynomial_ring(ZZ, :x => (-3:4)); julia> x[1] x[-3] julia> x[5] x[1] ```...

Replace some `setprecision!(::ParentObject)`

3

This replaces many `setprecision!(::ParentObject)` calls by `with_precision` blocks. ~Also removes `prime_field` in the context of local fields.~

Elliptic fibration book example errors

10

The book example in the file `specialized/brandhorst-zach-fibration-hopping/vinberg_3.jlcon` errors both on OSCAR 1.1 and current master: ``` julia> K = QQ; julia> Kt, t = polynomial_ring(K, :t); julia> Ktf = fraction_field(Kt);...

This doesn't work: ``` julia> M = matrix(ZZ, [ 1 2 3 ; 4 5 6]) [1 2 3] [4 5 6] julia> view(M, 1, 1) ERROR: StackOverflowError: Stacktrace: [1]...

Breaking changes for the p-adics

2

So we don't forget about this.

Fix a bug in gcd for polynomials

6

I don't know what this function is doing, so this is an educated guess. For polynomials over fields, another `gcd` is used. The function fixed here is only called if...

Make comparison of polynomials error if parent check fails

1

One way to resolve https://github.com/oscar-system/Oscar.jl/issues/4107 . Let's see what CI says.