Johannes Schmitt

> I've rebased the changes now and the only book tests that are failing are pertaining to areas that this PR is not touching. Is there anything else left to...

I think the problem is that the parent of `h` is equal to `G` but not identical: ``` julia> parent(h) == G true julia> parent(h) === G false ``` I...

The $p$-adic fields are now User-Friendly (TM), so one does not need to give the precision. The recommended way of generating a $p$-adic field is now `padic_field(3)`. Or possibly `padic_field(3,...

First of all, I should point out the difference between Julia matrices and AbstractAlgebra matrices. You can read the details here: https://docs.oscar-system.org/stable/General/faq/#Frequently-Asked-Questions (scroll to the question "Why do you have...

The documentation of `groebner_walk` indeed promises a reduced basis. @ooinaruhugh @fpnowell Is that incorrect? EDIT: If I am not completely mistaken, the output of `groebner_walk` is not a Gröbner basis:...

This issue could be resolved by putting `sort!` in this line https://github.com/oscar-system/Oscar.jl/blob/df4cb236e0f9ce4392752276b53ad1bb4e13b55c/src/Rings/orderings.jl#L1296 However, people with a higher pay grade than me should be certain that the current behaviour is a...

Thank you for the report! I bisected this regression to the update to Singular.jl 0.28, so the first "slow" commit is 59de5b6b9b0506f3ebfeab783a4ed718fdecd287. Any idea what happened there @YueRen @ederc @hannes14...

> It is not supposed to be superior to both its predecessor JSON 0.x, and also the JSON3 package. "not" or maybe "now"? (I'm honestly confused, not just pedantic.)

We have `n_partitions`/`number_of_partitions`. If I remember correctly, a multicombination is the same thing as a weak composition: if $(i_1,\dots,i_k)$ is a weak composition of $n$, so $i_j \geq 0$ and...

> > So here is an addition to my feature request: Ideally we should also mention alternative names for concepts that are used in the literature. I.e. I don't care...