Johannes Schmitt
Johannes Schmitt
Looks like there is an `assert` that effectively prevents one from setting the precision back to an earlier value. I also just realized that the field `.precision` of the map...
> hm, where did that > > ``` > function Base.setprecision(a::Generic.MatSpaceElem{QadicFieldElem}, N::Int) > b = deepcopy(a) > setprecision!(b, N) > return b > end > ``` > > move to...
I would like to emphasize that I am in favour of having `trim_trailing_whitespace` set to `true`. However, my general opinion on the formatting discussions in the past weeks is that...
Looks like it is related to #3413.
I assume that this can be closed.
There is a lot of (automatic) white space changes in here which makes you the author of these lines at first glance. Can you get your editor to not strip...
> This should really be added to `.editorconfig`! It's in there but commented out. Presumably because of problems like this.
Well, then make a pull request. I assume it's less a convention and more accepting reality though.
> Also, I think in detailed view it might make sense to print generators again, at least in some cases, e.g. for permutation groups; and for matrix groups it would...
> This PR is big and has been sitting here since May. I tried to give it a review, but the `precision` changes seem rather delicate to me, and there...