jquery-bbq icon indicating copy to clipboard operation
jquery-bbq copied to clipboard

Removed $.browser to support jQuery 1.9

Open joshlangner opened this issue 12 years ago • 5 comments

jQuery 1.9 removes $.browser. Some limited testing (IE 7-10, Safari 5, 6, Chrome 24, Firefox 18) suggests that this should be enough.

joshlangner avatar Jan 15 '13 18:01 joshlangner

are you sure this is a valid fix? now the code is always run when !supports_onhashchange is true whereas before it was only run when executed in IE.

joscha avatar Jan 16 '13 17:01 joscha

Its only checking for IE that is missing, right, so how about changing that code to:

(navigator.userAgent.match(/MSIE/i) !== null)

?

joscha avatar Jan 17 '13 21:01 joscha

I sent a pull onto your fork, if you want to add that to this pull.

joscha avatar Jan 17 '13 21:01 joscha

What about IE9 and IE10? Will they handled properly?

Nickproger avatar Apr 06 '13 17:04 Nickproger

works with Firefox 58.0.2 (32-bit)

nuwandharshana avatar Feb 14 '18 08:02 nuwandharshana