Jonathan Rico
Jonathan Rico
> Please do not use ztest_mock, it's actively being removed. Use FFF instead. Yes we know about it. As @ahmedmoheb-nordic is still ramping up on zephyr, we'll try to merge...
Since ahmed didn't mention it, here's the following PR he's talking about @yperess https://github.com/zephyrproject-rtos/zephyr/pull/48461
I think the PR looks much better now, comments are more descriptive, has been migrated to the new ztest API, etc. I only have some minor nits, and then we...
~~whoops looks like I forgot to review the test, it's still littered with commented code and is missing the new alloc_seg callback. Adding DNM until I fix it. The rest...
Sorry for the force-pushing @jhedberg I just noticed the checkpatch warnings.
@kfatehi I had a look, and it seems you're right, this is a limitation only for apple devices, you pretty much can't use directed advertising. @morsisko Could you add a...
Just to add some more info: This sample as-is will indeed not work on some peers that use bt privacy. In that case, one can as you said @kfatehi use...
> @jori-nordic > > Is such warning ok, or do you want to modify something?: > > `Please note that direct advertising towards iOS based devices is not possible. For...
Thanks for the thorough explanation @sjanc !
I agree, we should merge this as-is, else it's just scope creep. This sample clearly says it _will_ use directed advertising. A future PR would be nice ofc, in that...