esy-issues

esy-issues copied to clipboard

Implementing locking to prevent concurrent builds from racing with each other

4

We need to implement locking so that concurrent builds for the same package won't race. See flock or... suggestions?

andreypopp

It would be great to render to ninja instead of makefiles, so that we could run builds on windows as well. (Powershell is another option)

jordwalke

Faster `esy` env for global installs.

4

I'm making global packages for things like `refmt`, and they expose wrapper scripts that simply defer to `esy refmt`. That's great, but that seems to be incurring an additional `50ms`...

jordwalke

We should document the `buildsInSource` field and add it to the `PackageJsonForCompilers` spec.

jordwalke

Story for global installations

3

An alternative to `npm install --global`. Two options I see now. 1) Suggest users to make some default esy sandbox and do install there, also source its environment in `.profile`....

andreypopp

Pulled out from https://github.com/jordwalke/esy/issues/53#issuecomment-277410905 It'd be great to selectively purge packages. Helps coping with #53 and #59

chenglou

What happens when we're pointing to a git branch that's been force pushed?

5

I _think_ I've encountered some problems around this. I've force pushed to a few repos. The install hung forever. Sorry for being vague, can't get a good repro right now....

chenglou

Right now it gives: ``` (node:98869) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: fetch failed with status code 404 Error: fetch failed with status code 404 at Request. (/usr/local/lib/node_modules/esy/node_modules/npm-registry-client/lib/fetch.js:58:14)...

chenglou

Question: Can this be solved by including our own realpath implementation?

2

See this line here: https://github.com/jordwalke/esy/blob/master/.bin/esy#L5 Can our own provided `realpath` implementation work correctly instead of this snippet? @yunxing @andreypopp

jordwalke

Changing dependency path doesn't invalidate node_modules

3

Repro: change `"bs-platform": "esy-ocaml/bucklescript#esy"` to `"bs-platform": "/path/to/local/bucklescript"`, then do `esy install` while having an existing node_modules.

chenglou